Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15068 )
Change subject: WIP IMPALA-9242: Filter privileges before returning them to Sentry ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/15068/2/fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationPolicy.java File fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationPolicy.java: http://gerrit.cloudera.org:8080/#/c/15068/2/fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationPolicy.java@110 PS2, Line 110: public Set<String> listPrivileges(Set<String> groups, Set<String> users, > line too long (97 > 90) Done http://gerrit.cloudera.org:8080/#/c/15068/1/fe/src/main/java/org/apache/impala/catalog/Principal.java File fe/src/main/java/org/apache/impala/catalog/Principal.java: http://gerrit.cloudera.org:8080/#/c/15068/1/fe/src/main/java/org/apache/impala/catalog/Principal.java@85 PS1, Line 85: * Returns all privilege names for this principal, or an empty set if no privileges are > "or an empty set of no privileges" should be "or an empty set if no privile Done http://gerrit.cloudera.org:8080/#/c/15068/1/fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java File fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java: http://gerrit.cloudera.org:8080/#/c/15068/1/fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java@196 PS1, Line 196: case TABLE: > the condition check logic is not correct. Done http://gerrit.cloudera.org:8080/#/c/15068/2/fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java File fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java: http://gerrit.cloudera.org:8080/#/c/15068/2/fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java@200 PS2, Line 200: && (table_ == null || table_.equalsIgnoreCase(privilege.getTable_name())); > line too long (91 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/15068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecd4281368d1c9fe88cfe850ea725cd68895712e Gerrit-Change-Number: 15068 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Anonymous Coward (498) Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 21 Jan 2020 17:52:48 +0000 Gerrit-HasComments: Yes
