Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14705 )
Change subject: [KUDU-2632] Added support of Kudu DATE type to Impala ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/14705/8/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: http://gerrit.cloudera.org:8080/#/c/14705/8/be/src/exec/kudu-util.cc@135 PS8, Line 135: return Status(TErrorCode::RUNTIME_ERROR, "Invalid DateValue"); : } > nit: single line Done http://gerrit.cloudera.org:8080/#/c/14705/8/be/src/exec/kudu-util.cc@195 PS8, Line 195: KUDU_RETURN_IF_ERROR(row->SetDate(col, days), "Could not set Kudu row value."); : break; > nit: single line Done http://gerrit.cloudera.org:8080/#/c/14705/8/be/src/exec/kudu-util.cc@290 PS8, Line 290: RETURN_IF_ERROR(ConvertDateValue(reinterpret_cast<const DateValue*>(value), &days)); : *out = KuduValue::FromInt(days); > nit: single line Done http://gerrit.cloudera.org:8080/#/c/14705/8/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/14705/8/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@155 PS8, Line 155: valdate date default null) > Is there a test anywhere for trying to create a table with an invalid DATE Done -- To view, visit http://gerrit.cloudera.org:8080/14705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91656749a58ac769b54c2a63bdd4f85c89520b32 Gerrit-Change-Number: 14705 Gerrit-PatchSet: 9 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Tue, 21 Jan 2020 04:44:28 +0000 Gerrit-HasComments: Yes
