Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14705 )
Change subject: IMPALA-8800: Added support of Kudu DATE type to Impala This patch supports reading and writing DATE values to Kudu tables. It does not add min-max filter runtime support, but there is followup JIRA [IMPALA-9294]. Corresponding Kudu JIRA is [KUDU-2632] ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/14705/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14705/11//COMMIT_MSG@10 PS11, Line 10: [ What's the benefit of enclosing the JIRA id into the brackets? Or that's a requirement for the Impala repo? http://gerrit.cloudera.org:8080/#/c/14705/11//COMMIT_MSG@8 PS11, Line 8: This patch supports reading and writing DATE values : to Kudu tables. It does not add min-max filter runtime : support, but there is followup JIRA [IMPALA-9294]. : Corresponding Kudu JIRA is [KUDU-2632] Add an empty line to separate the summary and the longer description of the patch. For more or less universal git guidelines, please see https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines (BTW, it's referenced from https://kudu.apache.org/docs/contributing.html#_submitting_patches as well). http://gerrit.cloudera.org:8080/#/c/14705/8/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/14705/8/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@363 PS8, Line 363: Unpartitioned Kudu tables are inefficient for large data sizes. > I tested Kudu range partitioning with DATE key. Impala cannot parse DATE co Whoops, that's sounds like something expected. Would using functions as in https://impala.apache.org/docs/build/html/topics/impala_datetime_functions.html#datetime_functions__to_date help there? Otherwise, does it make sense to at least file a JIRA to track the issue or failure to parse DATE constants in PARTITION BY RANGE clause? -- To view, visit http://gerrit.cloudera.org:8080/14705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91656749a58ac769b54c2a63bdd4f85c89520b32 Gerrit-Change-Number: 14705 Gerrit-PatchSet: 11 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Wed, 22 Jan 2020 18:45:04 +0000 Gerrit-HasComments: Yes
