Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15281
Change subject: IMPALA-4080 [part 3]: Moved codegen code for TupleRowComparator into a Config object ...................................................................... IMPALA-4080 [part 3]: Moved codegen code for TupleRowComparator into a Config object This introduces a new class called TupleRowComparatorConfig that houses the fragment level parameters needed to create a TupleRowComparator object. It also codegens the TupleRowComparator::Compare() method that is shared by all instances of TupleRowComparator objects created using this config. Also, moved the related code to initiate codegen on this class for the exchange, sort, partial sort and top-n nodes from their exec nodes to their plan nodes. Lastly, this also moved the code responsible for codegening TopNNode::InsertBatch() from its exec node to its plan node. Testing: Sucessfully exhaustive tests. Manually verified that codegen works for all modified exec nodes. Change-Id: I265604ecbae2c80ff59e697fddfeea4976b25cd9 --- M be/src/exec/exchange-node.cc M be/src/exec/exchange-node.h M be/src/exec/partial-sort-node.cc M be/src/exec/partial-sort-node.h M be/src/exec/sort-node.cc M be/src/exec/sort-node.h M be/src/exec/topn-node.cc M be/src/exec/topn-node.h M be/src/runtime/data-stream-test.cc M be/src/runtime/sorter.cc M be/src/runtime/sorter.h M be/src/util/tuple-row-compare.cc M be/src/util/tuple-row-compare.h 13 files changed, 174 insertions(+), 103 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/15281/1 -- To view, visit http://gerrit.cloudera.org:8080/15281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I265604ecbae2c80ff59e697fddfeea4976b25cd9 Gerrit-Change-Number: 15281 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]>
