Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/15281 )
Change subject: IMPALA-4080 [part 3]: Moved codegen code for TupleRowComparator into a Config object ...................................................................... Patch Set 1: (1 comment) Looks good to me. http://gerrit.cloudera.org:8080/#/c/15281/1/be/src/exec/topn-node.cc File be/src/exec/topn-node.cc: http://gerrit.cloudera.org:8080/#/c/15281/1/be/src/exec/topn-node.cc@111 PS1, Line 111: // TODO: inline tuple_row_less_than_->Compare() It this comment still valid? -- To view, visit http://gerrit.cloudera.org:8080/15281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I265604ecbae2c80ff59e697fddfeea4976b25cd9 Gerrit-Change-Number: 15281 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2020 17:59:27 +0000 Gerrit-HasComments: Yes
