Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15281 )
Change subject: IMPALA-4080 [part 3]: Moved codegen code for TupleRowComparator into a Config object ...................................................................... Patch Set 1: (5 comments) This basically looks good, just have some minor comments. http://gerrit.cloudera.org:8080/#/c/15281/1/be/src/exec/exchange-node.h File be/src/exec/exchange-node.h: http://gerrit.cloudera.org:8080/#/c/15281/1/be/src/exec/exchange-node.h@49 PS1, Line 49: TupleRowComparatorConfig* row_comparator_config_ = nullptr; Can this be const? http://gerrit.cloudera.org:8080/#/c/15281/1/be/src/exec/topn-node.h File be/src/exec/topn-node.h: http://gerrit.cloudera.org:8080/#/c/15281/1/be/src/exec/topn-node.h@61 PS1, Line 61: InsertBatchFn codegend_insert_batch_fn_; init to nullptr? http://gerrit.cloudera.org:8080/#/c/15281/1/be/src/util/tuple-row-compare.h File be/src/util/tuple-row-compare.h: http://gerrit.cloudera.org:8080/#/c/15281/1/be/src/util/tuple-row-compare.h@70 PS1, Line 70: TupleRowComparatorConfig(const std::vector<ScalarExpr*>& ordering_exprs, Would it make sense to pass in TSortInfo? Not sure how invasive that is. http://gerrit.cloudera.org:8080/#/c/15281/1/be/src/util/tuple-row-compare.h@82 PS1, Line 82: std::vector<int8_t> nulls_first_; Might be a good idea to document nulls_first while we're here - i.e. the -1/1 thing. http://gerrit.cloudera.org:8080/#/c/15281/1/be/src/util/tuple-row-compare.h@87 PS1, Line 87: codegend_compare_fn_ init to null? -- To view, visit http://gerrit.cloudera.org:8080/15281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I265604ecbae2c80ff59e697fddfeea4976b25cd9 Gerrit-Change-Number: 15281 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 24 Feb 2020 19:58:04 +0000 Gerrit-HasComments: Yes
