Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15199 )
Change subject: IMPALA-5308: Resolve confusing Kudu SHOW TABLE STATS output ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15199/3/docs/topics/impala_show.xml File docs/topics/impala_show.xml: http://gerrit.cloudera.org:8080/#/c/15199/3/docs/topics/impala_show.xml@979 PS3, Line 979: +-------------+-------+ : | Stat | Value | : +-------------+-------+ : | Format | KUDU | : | #Rows | 2000 | : | #Partitions | 10 | : +-------------+-------+ we should be consist with how stats are displayed for HDFS tables: show table stats tpch.lineitem; +---------+--------+----------+--------------+-------------------+--------+-------------------+-----------------------------------------------------+ | #Rows | #Files | Size | Bytes Cached | Cache Replication | Format | Incremental stats | Location | +---------+--------+----------+--------------+-------------------+--------+-------------------+-----------------------------------------------------+ | 6001215 | 1 | 718.94MB | NOT CACHED | NOT CACHED | TEXT | false | hdfs://localhost:20500/test-warehouse/tpch.lineitem | +---------+--------+----------+--------------+-------------------+--------+-------------------+-----------------------------------------------------+ So the rows and columns should be inverted. It should look like this: +-------------+-------------+ | #Rows | #Partitions | +-------------+-------------+ | 2000 | 10 | +-------------+-------------+ http://gerrit.cloudera.org:8080/#/c/15199/3/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java: http://gerrit.cloudera.org:8080/#/c/15199/3/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@245 PS3, Line 245: nit: extra newline -- To view, visit http://gerrit.cloudera.org:8080/15199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4b8df65f0a53fe14b8fbe35d82c9887ab9a041 Gerrit-Change-Number: 15199 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2020 19:28:20 +0000 Gerrit-HasComments: Yes
