Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15199 )
Change subject: IMPALA-5308: Resolve confusing Kudu SHOW TABLE STATS output ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/15199/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15199/4//COMMIT_MSG@9 PS4, Line 9: S typo http://gerrit.cloudera.org:8080/#/c/15199/4/docs/topics/impala_show.xml File docs/topics/impala_show.xml: http://gerrit.cloudera.org:8080/#/c/15199/4/docs/topics/impala_show.xml@972 PS4, Line 972: file format maybe remove this since there is a "format" column in the new output http://gerrit.cloudera.org:8080/#/c/15199/4/docs/topics/impala_show.xml@1002 PS4, Line 1002: | -1 | 1 | 370.45MB | NOT CACHED | TEXT | false | Not your change obviously but I guess the hdfs examples in this file are mostly wrong, both here (eg. Locations column isn't shown) and for 'show partitions' below. Can you file a JIRA for that? http://gerrit.cloudera.org:8080/#/c/15199/4/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java: http://gerrit.cloudera.org:8080/#/c/15199/4/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@143 PS4, Line 143: org.apache.kudu.client.KuduTable kuduTable = Looks like we might also be able to get the size of the table, i.e. with kuduTable.getTableStatistics().getOnDiskSize(). Might be nice to add since the HDFS output has "Size" shown http://gerrit.cloudera.org:8080/#/c/15199/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/15199/4/fe/src/main/java/org/apache/impala/service/Frontend.java@1188 PS4, Line 1188: return FeKuduTable.Utils.getTableStats((FeKuduTable) table); maybe add a Preconditions.checkState(op == TShowStatsOp.TABLE) -- To view, visit http://gerrit.cloudera.org:8080/15199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4b8df65f0a53fe14b8fbe35d82c9887ab9a041 Gerrit-Change-Number: 15199 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Fri, 28 Feb 2020 18:24:42 +0000 Gerrit-HasComments: Yes
