Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15199 )
Change subject: IMPALA-5308: Resolve confusing Kudu SHOW TABLE STATS output ...................................................................... Patch Set 6: (4 comments) Patch is looking good, just a few more minor things and this can go in http://gerrit.cloudera.org:8080/#/c/15199/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15199/6//COMMIT_MSG@9 PS6, Line 9: S typo http://gerrit.cloudera.org:8080/#/c/15199/6/docs/topics/impala_show.xml File docs/topics/impala_show.xml: http://gerrit.cloudera.org:8080/#/c/15199/6/docs/topics/impala_show.xml@987 PS6, Line 987: Impala only computes the number of rows for the whole Kudu table, partition level Maybe move this down with the 'show partitions' example below http://gerrit.cloudera.org:8080/#/c/15199/6/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/15199/6/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@102 PS6, Line 102: " must target an HDFS or Kudu " : + "table: " nit: cleaner to just move the whole string to the next line instead of breaking it up into two strings http://gerrit.cloudera.org:8080/#/c/15199/6/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java: http://gerrit.cloudera.org:8080/#/c/15199/6/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@136 PS6, Line 136: STRING Looks like hdfs 'show stats' uses BIGINT for #Rows, lets be consistent with that, and the same for "#Partitions". -- To view, visit http://gerrit.cloudera.org:8080/15199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4b8df65f0a53fe14b8fbe35d82c9887ab9a041 Gerrit-Change-Number: 15199 Gerrit-PatchSet: 6 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 16 Mar 2020 18:18:26 +0000 Gerrit-HasComments: Yes
