Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 )
Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/15378/6/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/15378/6/shell/impala_client.py@933 PS6, Line 933: _do_hs2_rpc > do we know what is causing the 5xx errors? are the 5xx errors a symptom of We could probably use `_ping_impala_service` which uses the same transport. But, looking at the thrift http client code, it refreshes the connection for every request: https://github.com/apache/thrift/blob/master/lib/py/src/transport/THttpClient.py#L144 With the flush refreshing connection for every rpc, I am not sure if we need to explicitly re connect. I am going to test this by simulating connection drops. As for 5xx errors, I think we've seen these if intermediate gateway or proxy is not able to handle http requests for one reason or other. And In case of connection drops, I suspect we've seen EOFErrors when reading http response. -- To view, visit http://gerrit.cloudera.org:8080/15378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0da9e9e8d34a340eaf763397cc095ff6260d65d5 Gerrit-Change-Number: 15378 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Thu, 12 Mar 2020 03:18:18 +0000 Gerrit-HasComments: Yes
