Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 )
Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/15378/6/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/15378/6/shell/impala_client.py@933 PS6, Line 933: _do_hs2_rpc > We could probably use `_ping_impala_service` which uses the same transport. hmm thats interesting, I just assumed it was using HTTP Keep-Alive, but if it just re-establishes the connection per request, that seems like it should be okay. testing with connection drops would be great. however, that makes me wonder why this issue would ever come up in the first place? if the drain timeout in NGINX is 5 minutes, as long as no HTTP request lasts longer than 5 minutes, we should be okay? i would guess that the 502 errors are returned from NGINX if there are connection drops in Istio? when NGINX drops connections, I assume it doesn't send any HTTP error code, right? it just drops the connection and we get the EOFErrors -- To view, visit http://gerrit.cloudera.org:8080/15378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0da9e9e8d34a340eaf763397cc095ff6260d65d5 Gerrit-Change-Number: 15378 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Thu, 12 Mar 2020 16:03:16 +0000 Gerrit-HasComments: Yes
