Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 )
Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/15378/6/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/15378/6/shell/impala_client.py@933 PS6, Line 933: _do_hs2_rpc > I was able to test connection drops by killing worker processes in nginx. yeah, it would be good to understand why we still see failed rpcs then. its possible some RPCs take longer than 240 seconds under high load, although I'm not sure. given my current understanding of the nginx + istio issues, i'm still not sure why the retries are necessary. if RPCs finish under 240 seconds, then no connection should be dropped. looks like test_connection_drop confirms that the connection is reset between rpcs, which is good to know and validate. regardless, retrying idempotent rpcs is probably good to do in general, so I think this patch makes sense. dealing with non-idempotent rpcs will be trickier, so if we can find a way to avoid doing that (e.g. is there something else in istio / nginx causing the connection drops?), that would be nice. -- To view, visit http://gerrit.cloudera.org:8080/15378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0da9e9e8d34a340eaf763397cc095ff6260d65d5 Gerrit-Change-Number: 15378 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2020 17:50:01 +0000 Gerrit-HasComments: Yes
