Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15473 )
Change subject: IMPALA-8533: Impala daemon crash on sort ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15473/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/15473/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@366 PS1, Line 366: if(sortInfo.getSortTupleDescriptor().getSlots().size() > 0) { Should this same check be added for Sorts in other types of plans, not only for the Analytic functions ? e.g when creating the sort in SingleNodePlanner - either a total sort or a sort with limit. Do those work correctly for the case where an ORDER BY occurs after a UNION which is projecting a constant literal ? -- To view, visit http://gerrit.cloudera.org:8080/15473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If19303fbf55927c1e1b76b9b22ab354322b21c54 Gerrit-Change-Number: 15473 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Mar 2020 02:52:37 +0000 Gerrit-HasComments: Yes
