Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15473 )
Change subject: IMPALA-8533: Impala daemon crash on sort ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/15473/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15473/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-8533: Impala daemon crash on sort Suggest adding the word 'Fix' at the beginning. http://gerrit.cloudera.org:8080/#/c/15473/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/15473/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@366 PS1, Line 366: if(sortInfo.getSortTupleDescriptor().getSlots().size() > 0) { > I added several more testcases to increase coverage. Some of the cases appe Thanks for adding the tests. So looks like this crash was only occurring for the analytic function + union queries. http://gerrit.cloudera.org:8080/#/c/15473/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/15473/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@977 PS2, Line 977: /* Was this commented out for debugging ? http://gerrit.cloudera.org:8080/#/c/15473/2/testdata/workloads/functional-planner/queries/PlannerTest/union.test File testdata/workloads/functional-planner/queries/PlannerTest/union.test: http://gerrit.cloudera.org:8080/#/c/15473/2/testdata/workloads/functional-planner/queries/PlannerTest/union.test@4577 PS2, Line 4577: SELECT 1 FROM (SELECT int_col c1 FROM functional.alltypestiny UNION ALL SELECT int_col c1 FROM functional.alltypestiny) a ORDER BY 1; It would be good to add a short comment about what each of these tests is testing. e.g 'ordering by a constant ofter a union, so you expect the sort to be dropped' -- To view, visit http://gerrit.cloudera.org:8080/15473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If19303fbf55927c1e1b76b9b22ab354322b21c54 Gerrit-Change-Number: 15473 Gerrit-PatchSet: 2 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Mar 2020 17:45:42 +0000 Gerrit-HasComments: Yes
