Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/15473 )
Change subject: IMPALA-8533: Impala daemon crash on sort ...................................................................... Patch Set 2: (1 comment) Added more testcases. http://gerrit.cloudera.org:8080/#/c/15473/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/15473/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@366 PS1, Line 366: if(sortInfo.getSortTupleDescriptor().getSlots().size() > 0) { > Should this same check be added for Sorts in other types of plans, not only I added several more testcases to increase coverage. Some of the cases appear to have sorts that could be eliminated but are not. -- To view, visit http://gerrit.cloudera.org:8080/15473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If19303fbf55927c1e1b76b9b22ab354322b21c54 Gerrit-Change-Number: 15473 Gerrit-PatchSet: 2 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2020 15:21:02 +0000 Gerrit-HasComments: Yes
