Abhishek Rawat has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15378 )

Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15378/11/shell/impala_client.py
File shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/15378/11/shell/impala_client.py@656
PS11, Line 656:     if self.max_tries == 1:
              :       return 0
              :     ratio = float(num_tries) / self.max_tries
              :     if ratio < 0.3:
              :       return 0.1
              :     elif ratio < 0.6:
              :       return 0.3
              :     return 2
> The current logic basically has following (We have 3 tries total including
I ended up using a simple function same as what you've suggested: 
retry_interval = (num_tries - 1) * self.sleep_interval.
The behavior can be controlled by tweaking self.sleep_interval.

I also changed default self.max_tries to 4 (1 original try and 3 retries).



--
To view, visit http://gerrit.cloudera.org:8080/15378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0da9e9e8d34a340eaf763397cc095ff6260d65d5
Gerrit-Change-Number: 15378
Gerrit-PatchSet: 11
Gerrit-Owner: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Sahil Takiar <[email protected]>
Gerrit-Comment-Date: Mon, 23 Mar 2020 22:39:06 +0000
Gerrit-HasComments: Yes

Reply via email to