Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 )
Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol ...................................................................... Patch Set 14: Code-Review+1 (4 comments) A few more nits, otherwise LGTM. http://gerrit.cloudera.org:8080/#/c/15378/14/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/15378/14/shell/impala_client.py@946 PS14, Line 946: "TAPPLICATION_EXCEPTION" nit: make this a global string http://gerrit.cloudera.org:8080/#/c/15378/14/shell/impala_client.py@966 PS14, Line 966: "SERVER_ERROR" nit: same comment as above http://gerrit.cloudera.org:8080/#/c/15378/14/tests/custom_cluster/test_hs2_fault_injection.py File tests/custom_cluster/test_hs2_fault_injection.py: http://gerrit.cloudera.org:8080/#/c/15378/14/tests/custom_cluster/test_hs2_fault_injection.py@21 PS14, Line 21: import requests : from shell.ImpalaHttpClient import ImpalaHttpClient nit: insert newline between these two lines http://gerrit.cloudera.org:8080/#/c/15378/14/tests/custom_cluster/test_hs2_fault_injection.py@124 PS14, Line 124: expect_msg_retry since this is an internal testing method, it should be prefixed with __ same with expect_msg_no_retry -- To view, visit http://gerrit.cloudera.org:8080/15378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0da9e9e8d34a340eaf763397cc095ff6260d65d5 Gerrit-Change-Number: 15378 Gerrit-PatchSet: 14 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Wed, 25 Mar 2020 20:12:34 +0000 Gerrit-HasComments: Yes
