Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )
Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64 ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/common/compiler-util.h File be/src/common/compiler-util.h: http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/common/compiler-util.h@21 PS4, Line 21: #include "gutil/port.h" Instead of pulling another header in here, which pulls in more transitive dependencies, the locations that use CACHELINE_SIZE should just include gutil/port.h directly. http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/util/blocking-queue.h File be/src/util/blocking-queue.h: http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/util/blocking-queue.h@79 PS4, Line 79: // On aarch64 platform, size of mutex is 48, this DCHECK_NE will fail, Nit: reformat comment to fit on 2 lines http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/util/blocking-queue.h@81 PS4, Line 81: aglined nit: aligned http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/util/blocking-queue.h@82 PS4, Line 82: #ifndef __aarch64__ Is this change necessary after you added the padding? It seems like they should be separated now -- To view, visit http://gerrit.cloudera.org:8080/15705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171 Gerrit-Change-Number: 15705 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 21 Apr 2020 17:57:06 +0000 Gerrit-HasComments: Yes
