[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )
Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64 ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/util/blocking-queue.h File be/src/util/blocking-queue.h: http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/util/blocking-queue.h@82 PS4, Line 82: offsetof(BlockingQueue, get_lock_) / 64); > Is this change necessary after you added the padding? It seems like they sh Hi, Tim, you are right, it is not necessary, I already remove it. -- To view, visit http://gerrit.cloudera.org:8080/15705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171 Gerrit-Change-Number: 15705 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 22 Apr 2020 09:02:27 +0000 Gerrit-HasComments: Yes
