[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )
Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64 ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/common/compiler-util.h File be/src/common/compiler-util.h: http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/common/compiler-util.h@21 PS4, Line 21: #include "gutil/port.h" > Instead of pulling another header in here, which pulls in more transitive d Hi, Tim, except the blocking-queue.h, there are also other files use this CACHE_LINE_SIZE, such as aligned-new.h and hdfs-scanner.h, do you want me change them all to use CACHELINE_SIZE in gutil/port.h? -- To view, visit http://gerrit.cloudera.org:8080/15705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171 Gerrit-Change-Number: 15705 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 22 Apr 2020 08:40:19 +0000 Gerrit-HasComments: Yes
