wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15797 )
Change subject: IMPALA-9688: Support create iceberg table by impala ...................................................................... Patch Set 19: > (1 comment) > > Thanks for applying the changes. LGTM, however still have some > concerns about "file system tables"/"metastore tables". > (1 comment) > > Thanks for applying the changes. LGTM, however still have some > concerns about "file system tables"/"metastore tables". Hi Zoltan, I think I have found the cause of the error I describe above, impala latest branch use hive-3.1.3000.7.1.1.0-380, $IMPALA_HOME/toolchain/cdp_components-2523282/hive-3.1.3000.7.1.1.0-380/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java has constructor with parameter "Configuration", but iceberg rely on hive-2.3.6, you can refer this in https://github.com/apache/incubator-iceberg/blob/master/versions.props. And I check the source file of: https://github.com/apache/hive/blob/branch-2.3/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java which indeed has constructor with parameter "HiveConf", so when we use HiveCatalog.createTable, it will throw "NoSuchMethodError: org.apache.hadoop.hive.metastore.HiveMetaStoreClient.<init>(Lorg/apache/hadoop/hive/conf/HiveConf;)V" -- To view, visit http://gerrit.cloudera.org:8080/15797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d85db4c904a8c758c4cfb4f19cfbdab7e6ea284 Gerrit-Change-Number: 15797 Gerrit-PatchSet: 19 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2020 02:59:30 +0000 Gerrit-HasComments: No
