Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15797 )
Change subject: IMPALA-9688: Support create iceberg table by impala ...................................................................... Patch Set 20: Code-Review+1 (1 comment) Thanks for investigating HiveCatalog. The change LGTM, for now I give +1 to let other folks take a look as well in case I missed something. http://gerrit.cloudera.org:8080/#/c/15797/17/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/15797/17/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@24 PS17, Line 24: import org.apache.iceberg.hadoop.HadoopTableOperations; : import org.apache.iceberg.hadoop.HadoopTables; > Just do an "invalidate metadata" when create external table for Iceberg met I think for now it's probably good as it is, and I don't want to hold on the review either. And I saw your comment about Hive version incompatibilities so probably we won't resolve this in the near future. Later we'll likely need to use HiveCatalog if we want to support Iceberg on object stores like Amazon S3. As far as I can tell, with the current solution we are tied to HDFS, but I think it's OK for now. -- To view, visit http://gerrit.cloudera.org:8080/15797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d85db4c904a8c758c4cfb4f19cfbdab7e6ea284 Gerrit-Change-Number: 15797 Gerrit-PatchSet: 20 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2020 10:23:29 +0000 Gerrit-HasComments: Yes
