Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15797 )
Change subject: IMPALA-9688: Support create iceberg table by impala ...................................................................... Patch Set 23: (5 comments) http://gerrit.cloudera.org:8080/#/c/15797/23/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: http://gerrit.cloudera.org:8080/#/c/15797/23/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@258 PS23, Line 258: && getFileFormat() != THdfsFileFormat.KUDU && getFileFormat() != THdfsFileFormat.ICEBERG) { line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/15797/23/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@578 PS23, Line 578: throw new AnalysisException("Table requires at least 1 column for managed iceberg table."); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/15797/23/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java File fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java: http://gerrit.cloudera.org:8080/#/c/15797/23/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java@32 PS23, Line 32: //The field id from Iceberg PartitionField, which across all the table metadata's partition specs line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/15797/23/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/15797/23/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2547 PS23, Line 2547: // Iceberg tables are always unpartitioned. The partition columns are derived from the line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/15797/23/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2548 PS23, Line 2548: // TCreateTableParams.partition_spec field, and could include one or more of the table columns line too long (106 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d85db4c904a8c758c4cfb4f19cfbdab7e6ea284 Gerrit-Change-Number: 15797 Gerrit-PatchSet: 23 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Wed, 17 Jun 2020 14:38:12 +0000 Gerrit-HasComments: Yes
