Joe McDonnell has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15833 )
Change subject: IMPALA-9708: Remove Sentry support ...................................................................... IMPALA-9708: Remove Sentry support Impala 4 decided to drop Sentry support in favor of Ranger. This removes Sentry support and related tests. It retires startup flags related to Sentry and removes as much code as possible. Documentation will still need to be adjusted to remove references to Sentry. Some issues came up when implementing this. Here is a summary of how this patch resolves them: 1. authorization_provider currently defaults to "sentry", but "ranger" requires extra parameters to be set. This changes the default value of authorization_provider to "", which translates internally to the noop policy that does no authorization. 2. These flags are Sentry specific and are now retired: - authorization_policy_provider_class - sentry_catalog_polling_frequency_s - sentry_config 3. The authorization_factory_class may be obsolete now that there is only one authorization policy, but this leaves it in place. 4. Sentry is the last component using CDH_COMPONENTS_HOME, so that is removed. There are still Maven dependencies coming from the CDH_BUILD_NUMBER repository, so that is not removed. 5. To make the transition easier, testdata/bin/kill-sentry-service.sh is not removed and it is still called from testdata/bin/kill-all.sh. Testing: - Core job passes Change-Id: I8e99c15936d6d250cf258e3a1dcba11d3eb4661e --- M README-build.md M be/src/catalog/catalog-server.cc M be/src/catalog/catalog-service-client-wrapper.h M be/src/catalog/catalog.cc M be/src/catalog/catalog.h M be/src/common/global-flags.cc M be/src/exec/catalog-op-executor.cc M be/src/exec/catalog-op-executor.h M be/src/service/fe-support.cc M be/src/service/frontend.cc M be/src/transport/TSasl.cpp M be/src/util/backend-gflag-util.cc M bin/bootstrap_toolchain.py M bin/create-test-configuration.sh M bin/impala-config.sh M buildall.sh M common/thrift/BackendGflags.thrift M common/thrift/CatalogService.thrift M fe/pom.xml M fe/src/main/java/org/apache/impala/analysis/AlterDbSetOwnerStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java M fe/src/main/java/org/apache/impala/analysis/AuthorizationStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java M fe/src/main/java/org/apache/impala/authorization/AuthorizationProvider.java M fe/src/main/java/org/apache/impala/authorization/PrivilegeRequestBuilder.java D fe/src/main/java/org/apache/impala/authorization/sentry/ImpalaAction.java D fe/src/main/java/org/apache/impala/authorization/sentry/ImpalaActionFactory.java D fe/src/main/java/org/apache/impala/authorization/sentry/ImpalaPrivilegeModel.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthProvider.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizable.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizableColumn.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizableDb.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizableFactory.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizableFn.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizableServer.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizableTable.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizableUri.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationChecker.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationConfig.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationFactory.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationPolicy.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryConfig.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyReaderException.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryUnavailableException.java D fe/src/main/java/org/apache/impala/authorization/sentry/SentryUtil.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/main/java/org/apache/impala/service/FeSupport.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/main/java/org/apache/impala/service/JniCatalog.java M fe/src/main/java/org/apache/impala/util/AuthorizationUtil.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java D fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java M fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java D fe/src/test/java/org/apache/impala/authorization/sentry/ImpalaActionFactoryTest.java D fe/src/test/java/org/apache/impala/authorization/sentry/SentryProxyTest.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java D fe/src/test/java/org/apache/impala/testutil/SentryServicePinger.java D fe/src/test/java/org/apache/impala/testutil/TestSentryGroupMapper.java M fe/src/test/java/org/apache/impala/util/AuthorizationUtilTest.java M fe/src/test/resources/hive-site.xml.py D fe/src/test/resources/sentry-site.xml.py M impala-parent/pom.xml M infra/deploy/deploy.py M testdata/bin/run-all.sh M testdata/bin/run-hive-server.sh D testdata/bin/run-sentry-service.sh D testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test D testdata/workloads/functional-query/queries/QueryTest/grant_revoke_kudu.test D testdata/workloads/functional-query/queries/QueryTest/show_grant_user.test M tests/authorization/test_authorization.py M tests/authorization/test_authorized_proxy.py D tests/authorization/test_grant_revoke.py D tests/authorization/test_sentry.py M tests/common/custom_cluster_test_suite.py D tests/common/sentry_cache_test_suite.py M tests/common/skip.py 81 files changed, 94 insertions(+), 9,078 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/15833/5 -- To view, visit http://gerrit.cloudera.org:8080/15833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8e99c15936d6d250cf258e3a1dcba11d3eb4661e Gerrit-Change-Number: 15833 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
