Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15833 )
Change subject: IMPALA-9708: Remove Sentry support ...................................................................... Patch Set 5: > (1 comment) > > Thanks for doing the cleanup! Is this the part-1 and there will be > other patches for this JIRA? > > I think at least we can remove the catalog cache for > users/principals/privileges since they are only used for Sentry. > It's ok to do this in a separate patch since maybe a lot of codes > can be removed as well. > > Some works (IMPALA-9002, IMPALA-9195, IMPALA-9242, IMPALA-9222, > etc.) in the SHOW TABLES/DATABASES code path are done for Sentry, > they may can be removed/reverted as well. Let's plan on having follow-up code changes for removing further obsolete code. I'm open to doing that with followup JIRAs that we link to IMPALA-9708 or with further changes using IMPALA-9708 itself. For example, I know we will need to update docs, and Fang-Yu pointed out that we should consider removing "show roles". I updated the commit comment to indicate that this is the first round of removing code and that there will be further removal of obsolete code. -- To view, visit http://gerrit.cloudera.org:8080/15833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e99c15936d6d250cf258e3a1dcba11d3eb4661e Gerrit-Change-Number: 15833 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2020 23:33:48 +0000 Gerrit-HasComments: No
