Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15833 )
Change subject: IMPALA-9708: Remove Sentry support ...................................................................... Patch Set 5: Code-Review+2 Thanks for the cleanup! About removing more code that is only relevant in Sentry: I vote for merging this as it is and continue the cleanup in another patch. I understand if someone prefers to do this in one big patch, but removing Sentry tests and CDH dependencies would make test jobs faster and avoid some potential build issues/flakiness, so I think it would be better to merge these changes earlier. -- To view, visit http://gerrit.cloudera.org:8080/15833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e99c15936d6d250cf258e3a1dcba11d3eb4661e Gerrit-Change-Number: 15833 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2020 14:41:40 +0000 Gerrit-HasComments: No
