Bikramjeet Vig has uploaded this change for review. (
http://gerrit.cloudera.org:8080/16051
Change subject: IMPALA-9840: Fix data race in InternalQueue
......................................................................
IMPALA-9840: Fix data race in InternalQueue
This patch converts the remaining public methods in InternalQueue to
be thread safe. These methods were being used during multi threaded
execution and got flagged by thread sanitizer.
Performance:
Ran single node perf run with TPCH (scale factor 30) on my local to
make sure there was no perf impact.
+----------+-----------------------+---------+------------+------------+----------------+
| Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) |
Delta(GeoMean) |
+----------+-----------------------+---------+------------+------------+----------------+
| TPCH(30) | parquet / none / none | 6.17 | -1.59% | 4.33 | -0.30%
|
+----------+-----------------------+---------+------------+------------+----------------+
Change-Id: Ied72c4573e5d23ba744964c3e8a90851d9c6b31c
---
M be/src/util/internal-queue.h
1 file changed, 18 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/16051/2
--
To view, visit http://gerrit.cloudera.org:8080/16051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied72c4573e5d23ba744964c3e8a90851d9c6b31c
Gerrit-Change-Number: 16051
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <[email protected]>
