Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/16051 )
Change subject: IMPALA-9840: Fix data race in InternalQueue
......................................................................
IMPALA-9840: Fix data race in InternalQueue
This patch converts the remaining public methods in InternalQueue to
be thread safe. These methods were being used during multi threaded
execution and got flagged by thread sanitizer.
Performance:
Ran single node perf run with TPCH (scale factor 30) on my local to
make sure there was no perf impact.
+----------+-----------------------+---------+------------+------------+----------------+
| Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) |
Delta(GeoMean) |
+----------+-----------------------+---------+------------+------------+----------------+
| TPCH(30) | parquet / none / none | 6.17 | -1.59% | 4.33 | -0.30%
|
+----------+-----------------------+---------+------------+------------+----------------+
Change-Id: Ied72c4573e5d23ba744964c3e8a90851d9c6b31c
Reviewed-on: http://gerrit.cloudera.org:8080/16051
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M be/src/util/internal-queue.h
1 file changed, 18 insertions(+), 8 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied72c4573e5d23ba744964c3e8a90851d9c6b31c
Gerrit-Change-Number: 16051
Gerrit-PatchSet: 5
Gerrit-Owner: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Sahil Takiar <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
