Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16051 )
Change subject: IMPALA-9840: Fix data race in InternalQueue ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Carrying over Tim's +2 http://gerrit.cloudera.org:8080/#/c/16051/2/be/src/util/internal-queue.h File be/src/util/internal-queue.h: http://gerrit.cloudera.org:8080/#/c/16051/2/be/src/util/internal-queue.h@296 PS2, Line 296: inline int SizeLocked() const { return size_; } > nit: SizeLocked() for C++ code. Done http://gerrit.cloudera.org:8080/#/c/16051/2/be/src/util/internal-queue.h@297 PS2, Line 297: inline bool IsEmptyLocked() const { return head_ == nullptr; } > nit: EmptyLocked() or IsEmptyLocked() Done -- To view, visit http://gerrit.cloudera.org:8080/16051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied72c4573e5d23ba744964c3e8a90851d9c6b31c Gerrit-Change-Number: 16051 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2020 23:46:35 +0000 Gerrit-HasComments: Yes
