Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 )
Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API ...................................................................... Patch Set 14: Code-Review+2 (5 comments) Carry on Zoltan's +1. Please carry on my +2 after resolving the String.format() comment. Also left some minor comments. http://gerrit.cloudera.org:8080/#/c/16008/14/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/16008/14/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@20 PS14, Line 20: import com.codahale.metrics.Counter; nit: move this to line 102 http://gerrit.cloudera.org:8080/#/c/16008/14/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1552 PS14, Line 1552: String.format( We should not use String.format() here since we are using "{}" instead of "%s". The last argument of LOG.debug() can be a Throwable: https://github.com/qos-ch/slf4j/blob/v_1.7.25/slf4j-api/src/main/java/org/slf4j/helpers/MessageFormatter.java#L160-L163 http://gerrit.cloudera.org:8080/#/c/16008/14/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java File fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java: http://gerrit.cloudera.org:8080/#/c/16008/14/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@21 PS14, Line 21: import static org.junit.Assert.assertTrue; nit: can remove them since the following codes are not using these static import. http://gerrit.cloudera.org:8080/#/c/16008/14/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@42 PS14, Line 42: import org.apache.impala.thrift.TValidWriteIdList; nit: unused import http://gerrit.cloudera.org:8080/#/c/16008/14/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@223 PS14, Line 223: ValidWriteIdList olderWriteIdList = getValidWriteIdList(testDbName, : testPartitionedTbl); Can we simply get this by tbl.getValidWriteIds() instead of sending an HMS RPC? -- To view, visit http://gerrit.cloudera.org:8080/16008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied2c7c3cb2009c407e8fbc3af4722b0d34f57c4a Gerrit-Change-Number: 16008 Gerrit-PatchSet: 14 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 11 Jun 2020 02:50:21 +0000 Gerrit-HasComments: Yes
