Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 )
Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API ...................................................................... Patch Set 17: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/16008/17/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/16008/17/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@119 PS17, Line 119: import com.google.common.base.Stopwatch; nit: please sort this to line 116 http://gerrit.cloudera.org:8080/#/c/16008/17/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java File fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java: http://gerrit.cloudera.org:8080/#/c/16008/17/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@79 PS17, Line 79: impalaJdbcClient_ = ImpalaJdbcClient.createClientUsingHiveJdbcDriver(); nit: unused var http://gerrit.cloudera.org:8080/#/c/16008/17/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@111 PS17, Line 111: if (client != null) { nit: this is always true otherwise line 97 will fail first. Actually, ImpalaJdbcClient.createClientUsingHiveJdbcDriver() always returns nonnull values http://gerrit.cloudera.org:8080/#/c/16008/17/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@131 PS17, Line 131: if (client != null) { nit: this is always true otherwise line 127 will fail first -- To view, visit http://gerrit.cloudera.org:8080/16008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied2c7c3cb2009c407e8fbc3af4722b0d34f57c4a Gerrit-Change-Number: 16008 Gerrit-PatchSet: 17 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 12 Jun 2020 00:35:54 +0000 Gerrit-HasComments: Yes
