Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 )
Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API ...................................................................... Patch Set 19: Code-Review+2 (4 comments) Thanks for the review. Carrying over the +2 http://gerrit.cloudera.org:8080/#/c/16008/17/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java File fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java: http://gerrit.cloudera.org:8080/#/c/16008/17/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@79 PS17, Line 79: > nit: unused var Done http://gerrit.cloudera.org:8080/#/c/16008/17/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@106 PS17, Line 106: } finally { > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/16008/17/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@111 PS17, Line 111: talog_.reset(); > nit: this is always true otherwise line 97 will fail first. Actually, Impal Done http://gerrit.cloudera.org:8080/#/c/16008/17/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@131 PS17, Line 131: > nit: this is always true otherwise line 127 will fail first Done -- To view, visit http://gerrit.cloudera.org:8080/16008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied2c7c3cb2009c407e8fbc3af4722b0d34f57c4a Gerrit-Change-Number: 16008 Gerrit-PatchSet: 19 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 12 Jun 2020 01:05:50 +0000 Gerrit-HasComments: Yes
