Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16093 )
Change subject: IMPALA-9213: Add query retry info to GetLog result ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/16093/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16093/3//COMMIT_MSG@15 PS3, Line 15: This patch also modifies impala-shell to extract the retried query id : and print the retried query link. will this work for other clients like Hue or JDBC driver as well? or would they need to be modified? ideally this should work for Hue / JDBC without having to modify them. http://gerrit.cloudera.org:8080/#/c/16093/3//COMMIT_MSG@28 PS3, Line 28: WARNINGS: Original query failed: : Failed due to unreachable impalad(s): quanlong-OptiPlex-BJ:22001 : : Query has been retried using query id: 934b2734f67a1161:a0dbd60200000000 : Retried query link: http://quanlong-OptiPlex-BJ:25000/query_plan?query_id=934b2734f67a1161:a0dbd60200000000 is there a way to print this out before the results get returned? http://gerrit.cloudera.org:8080/#/c/16093/3/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: http://gerrit.cloudera.org:8080/#/c/16093/3/be/src/service/impala-beeswax-server.cc@354 PS3, Line 354: VLOG_RPC << "get_log(): query_id=" << PrintId(query_id) << ", log=" << log; I think you could probably move this to earlier in the method, as soon as query_id is set. that seems to be the pattern followed by most other methods in this class. http://gerrit.cloudera.org:8080/#/c/16093/3/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/16093/3/be/src/service/impala-hs2-server.cc@977 PS3, Line 977: VLOG_RPC << "GetLog(): query_id=" << PrintId(query_id) << ", log=" << return_val.log; same comment as in impala-beeswax-server.cc -- To view, visit http://gerrit.cloudera.org:8080/16093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cf94f91a0b92eb9a3088bee3894ac157a954dc Gerrit-Change-Number: 16093 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Thu, 18 Jun 2020 16:51:18 +0000 Gerrit-HasComments: Yes
