Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16093 )
Change subject: IMPALA-9213: Add query retry info to GetLog result ...................................................................... Patch Set 4: (4 comments) Thanks for the quick review! http://gerrit.cloudera.org:8080/#/c/16093/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16093/3//COMMIT_MSG@15 PS3, Line 15: This patch also modifies impala-shell to extract the retried query id : and print the retried query link. > will this work for other clients like Hue or JDBC driver as well? or would This work for other clients including old version of impala-shells if they invoke the get_log()/GetLog() RPCs and print the results. The only missing part is printing the retried query link. The query link needs to be constructed by the clients. To be specifit, old version of impala-shells will print this at the end of the query (missing the retried query link): WARNINGS: Original query failed: Failed due to unreachable impalad(s): quanlong-OptiPlex-BJ:22001 Query has been retried using query id: 934b2734f67a1161:a0dbd60200000000 http://gerrit.cloudera.org:8080/#/c/16093/3//COMMIT_MSG@28 PS3, Line 28: WARNINGS: Original query failed: : Failed due to unreachable impalad(s): quanlong-OptiPlex-BJ:22001 : : Query has been retried using query id: 934b2734f67a1161:a0dbd60200000000 : Retried query link: http://quanlong-OptiPlex-BJ:25000/query_plan?query_id=934b2734f67a1161:a0dbd60200000000 > is there a way to print this out before the results get returned? Yeah, I wrote it in the JIRA comment [1] and implemented it in the next patch for IMPALA-9569. [1] https://issues.apache.org/jira/browse/IMPALA-9213?focusedCommentId=17139012&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17139012 http://gerrit.cloudera.org:8080/#/c/16093/3/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: http://gerrit.cloudera.org:8080/#/c/16093/3/be/src/service/impala-beeswax-server.cc@354 PS3, Line 354: VLOG_RPC << "get_log(): query_id=" << PrintId(query_id) << ", log=" << log; > I think you could probably move this to earlier in the method, as soon as q I want to log the returned result so put this at the end. I think other methods log the query_id earlier since their results are too large to be logged so being ignored. I can add another log as soon as query_id is set if you want :) http://gerrit.cloudera.org:8080/#/c/16093/3/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/16093/3/be/src/service/impala-hs2-server.cc@977 PS3, Line 977: VLOG_RPC << "GetLog(): query_id=" << PrintId(query_id) << ", log=" << return_val.log; > same comment as in impala-beeswax-server.cc same comment as in impala-beeswax-server.cc that I want to log the returned result. -- To view, visit http://gerrit.cloudera.org:8080/16093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cf94f91a0b92eb9a3088bee3894ac157a954dc Gerrit-Change-Number: 16093 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Thu, 18 Jun 2020 23:28:46 +0000 Gerrit-HasComments: Yes
