Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16093 )
Change subject: IMPALA-9213: Add query retry info to GetLog result ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/16093/6/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: http://gerrit.cloudera.org:8080/#/c/16093/6/be/src/service/impala-beeswax-server.cc@327 PS6, Line 327: DCHECK(!original_query_handle->query_status().ok()); > might be worth adding a DCHECK right before this line asserting that '!orig Done http://gerrit.cloudera.org:8080/#/c/16093/6/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/16093/6/be/src/service/impala-hs2-server.cc@939 PS6, Line 939: DCHECK(!original_query_handle->query_status().ok()); > same comment as the beeswax version Done http://gerrit.cloudera.org:8080/#/c/16093/6/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/16093/6/be/src/service/impala-server.cc@366 PS6, Line 366: \n > don't think this is necessary? it looks like it is adding an extra new line I see we do the same thing at https://github.com/apache/impala/blob/a11b8b687a97c25d1df09cab4d0bb5d2101cbada/be/src/service/impala-beeswax-server.cc#L331 Maybe it's helpful to highlight the error when using impala-shell. I think we can keep it. Or do you think we should delete both of them? http://gerrit.cloudera.org:8080/#/c/16093/6/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/16093/6/shell/impala_client.py@337 PS6, Line 337: etried query link: %s" > instead of piping this through all these methods as a callback, can we just Yeah, the callback looks awkward. Refactored the codes to keep the webserver_address inside clients so we don't need the callback anymore. http://gerrit.cloudera.org:8080/#/c/16093/6/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/16093/6/shell/impala_shell.py@1072 PS6, Line 1072: _periodic_wait_callback( > nit: add some method code comments, rename to '_get_query_link' since it is Done -- To view, visit http://gerrit.cloudera.org:8080/16093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cf94f91a0b92eb9a3088bee3894ac157a954dc Gerrit-Change-Number: 16093 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Sun, 28 Jun 2020 06:36:43 +0000 Gerrit-HasComments: Yes
