Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16115 )
Change subject: [WIP] IMPALA-9898: Plan generation and execution for grouping sets ...................................................................... Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/16115/1/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/16115/1/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@355 PS1, Line 355: int outputSlotIdx = groupingExprs_.size() + 1; // add 1 to account for the tuple id column line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/16115/1/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@357 PS1, Line 357: outputSmap_.put(aggExprs_.get(i).clone(), new SlotRef(outputSlots.get(outputSlotIdx))); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16115/1/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@452 PS1, Line 452: * Note that all classes have the same aggregate output exprs but different grouping exprs. line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16115/1/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@523 PS1, Line 523: CaseExpr caseExpr = new CaseExpr(new ValidTupleIdExpr(aggTids), caseWhenClauses, null); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16115/1/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@551 PS1, Line 551: CaseExpr caseExpr = new CaseExpr(new ValidTupleIdExpr(aggTids), caseWhenClauses, null); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16115/1/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@564 PS1, Line 564: CaseExpr caseExprForTids = new CaseExpr(new ValidTupleIdExpr(aggTids), caseWhenClauses, null); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/16115/1/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@595 PS1, Line 595: CaseExpr caseExpr = new CaseExpr(new ValidTupleIdExpr(aggTids), caseWhenClauses, null); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16115/1/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@597 PS1, Line 597: // wrap this in an aggif expr because an AggregateInfo only allows either aggregate exprs line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id474c5373860b0d8014ee9c844a3fb90092be968 Gerrit-Change-Number: 16115 Gerrit-PatchSet: 1 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 26 Jun 2020 18:54:50 +0000 Gerrit-HasComments: Yes
