Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16115 )
Change subject: IMPALA-9898: Plan generation and execution for grouping sets ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16115/2/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/16115/2/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@544 PS2, Line 544: if (aggInfo.getGroupingExprs().size() == 0) { > I think it would be more efficient to support not providing the NULL groupi Yes, the NULL exprs are included in the intermediate tuples. I felt that getting the positional index right (for grouping_id/grouping function support) could be prone to bugs if all grouping sets did not have the fixed number of exprs. I have left this as-is for now in the latest patchset but if needed can do some refactoring as Part-2 based on the integration with your patch -- To view, visit http://gerrit.cloudera.org:8080/16115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id474c5373860b0d8014ee9c844a3fb90092be968 Gerrit-Change-Number: 16115 Gerrit-PatchSet: 3 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 30 Jun 2020 17:25:32 +0000 Gerrit-HasComments: Yes
