Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 )
Change subject: IMPALA-9902: add rewrite of TPC-DS q38 ...................................................................... Patch Set 1: Hi Tim, I am answering one of my questions regarding whether to update EXPECTED_TPCDS_QUERIES_COUNT from 72 to 73 at https://github.com/apache/impala/blob/master/tests/util/parse_util.py#L25. According to the logic in the function of load_tpc_queries() at https://github.com/apache/impala/blob/master/tests/util/test_file_parser.py#L348-L350, it seems that we only need to update EXPECTED_TPCDS_QUERIES_COUNT when adding tests with names containing "tpcds-demical_v2" and thus we do not need to change EXPECTED_TPCDS_QUERIES_COUNT if we do not add tests under the class of TestTpcdsDecimalV2Query. -- To view, visit http://gerrit.cloudera.org:8080/16118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81807683aa265a946729e15156bd2e33724103e1 Gerrit-Change-Number: 16118 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 28 Jun 2020 21:35:40 +0000 Gerrit-HasComments: No
