Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 )
Change subject: IMPALA-9902: add rewrite of TPC-DS q38 ...................................................................... Patch Set 2: (3 comments) Thanks for pointing out that I need to update the query count, I missed that originally. http://gerrit.cloudera.org:8080/#/c/16118/1/testdata/workloads/tpcds/queries/tpcds-q38.test File testdata/workloads/tpcds/queries/tpcds-q38.test: http://gerrit.cloudera.org:8080/#/c/16118/1/testdata/workloads/tpcds/queries/tpcds-q38.test@1 PS1, Line 1: : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : > I just found that HS2 is not able to compile the rewritten Q38 due to the f Yep, I also compared this to the hive results from the original query. http://gerrit.cloudera.org:8080/#/c/16118/1/testdata/workloads/tpcds/queries/tpcds-q8.test File testdata/workloads/tpcds/queries/tpcds-q8.test: http://gerrit.cloudera.org:8080/#/c/16118/1/testdata/workloads/tpcds/queries/tpcds-q8.test@4 PS1, Line 4: -- INTERSECT. > Thanks Tim for catching this! After checking $IMPALA_HOME/toolchain/toolcha Yeah I was going to add a rewrite of this cause it also used INTERSECT, then discovered that we'd already done it. http://gerrit.cloudera.org:8080/#/c/16118/1/tests/query_test/test_tpcds_queries.py File tests/query_test/test_tpcds_queries.py: http://gerrit.cloudera.org:8080/#/c/16118/1/tests/query_test/test_tpcds_queries.py@127 PS1, Line 127: def test_tpcds_q39_1(self, vector): > I am wondering if we need to add the modified Q38 under the class of TestTp I moved it to the decimal_v2 tests, I think that seems reasonable since that's the default behaviour. It shouldn't affect the result of the query. I added a -rewrite suffix to indicate that it was a rewrite. 38a makes it sound like an official variant. I think unfortunately a lot of these TPC-DS queries have undocumented tweaks to them, but we do have the Unmodified suite below at least. -- To view, visit http://gerrit.cloudera.org:8080/16118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81807683aa265a946729e15156bd2e33724103e1 Gerrit-Change-Number: 16118 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 29 Jun 2020 23:15:58 +0000 Gerrit-HasComments: Yes
