Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 )
Change subject: IMPALA-9902: add rewrite of TPC-DS q38 ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Thanks Tim for addressing my previous comments! I do not have any other suggestion. http://gerrit.cloudera.org:8080/#/c/16118/1/testdata/workloads/tpcds/queries/tpcds-q38.test File testdata/workloads/tpcds/queries/tpcds-q38.test: http://gerrit.cloudera.org:8080/#/c/16118/1/testdata/workloads/tpcds/queries/tpcds-q38.test@1 PS1, Line 1: : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : > Yep, I also compared this to the hive results from the original query. Ack http://gerrit.cloudera.org:8080/#/c/16118/1/testdata/workloads/tpcds/queries/tpcds-q8.test File testdata/workloads/tpcds/queries/tpcds-q8.test: http://gerrit.cloudera.org:8080/#/c/16118/1/testdata/workloads/tpcds/queries/tpcds-q8.test@4 PS1, Line 4: -- INTERSECT. > Yeah I was going to add a rewrite of this cause it also used INTERSECT, the Ack http://gerrit.cloudera.org:8080/#/c/16118/1/tests/query_test/test_tpcds_queries.py File tests/query_test/test_tpcds_queries.py: http://gerrit.cloudera.org:8080/#/c/16118/1/tests/query_test/test_tpcds_queries.py@127 PS1, Line 127: def test_tpcds_q39_1(self, vector): > I moved it to the decimal_v2 tests, I think that seems reasonable since tha Ack -- To view, visit http://gerrit.cloudera.org:8080/16118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81807683aa265a946729e15156bd2e33724103e1 Gerrit-Change-Number: 16118 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 30 Jun 2020 02:16:19 +0000 Gerrit-HasComments: Yes
