Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16267 )
Change subject: IMPALA-10017: Implement ds_kll_union() function ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16267/3/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/16267/3/be/src/exprs/aggregate-functions-ir.cc@1851 PS3, Line 1851: deserialize Can you add a try-catch block? I randomly checked a deserialize function and it can throw exception: https://github.com/apache/impala/blob/074731e2bcf37643710f2fdf236829991a462fc3/be/src/thirdparty/datasketches/HllSketchImplFactory.hpp#L86 It would be nice to do this for other similar calls to datasketches functions too. http://gerrit.cloudera.org:8080/#/c/16267/3/be/src/exprs/aggregate-functions-ir.cc@1922 PS3, Line 1922: dst_sketch->merge(src_sketch); merge can throw an exception, please put it in a try-catch block: https://github.com/apache/impala/blob/074731e2bcf37643710f2fdf236829991a462fc3/be/src/thirdparty/datasketches/kll_sketch_impl.hpp#L182 -- To view, visit http://gerrit.cloudera.org:8080/16267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I020aea28d36f9b6ef9fb57c08411f2170f5c24bf Gerrit-Change-Number: 16267 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 05 Aug 2020 15:10:57 +0000 Gerrit-HasComments: Yes
