Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16267 )
Change subject: IMPALA-10017: Implement ds_kll_union() function ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16267/3/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/16267/3/be/src/exprs/aggregate-functions-ir.cc@1851 PS3, Line 1851: etch)) { > Can you add a try-catch block? I randomly checked a deserialize function an The code you linked is urelated here, it is for HLL sketches. However, the one for KLL ca also throw: https://github.com/apache/impala/blob/074731e2bcf37643710f2fdf236829991a462fc3/be/src/thirdparty/datasketches/kll_sketch_impl.hpp#L534 E.g. ensure_minimum_memory() throws, haven't checked the rest, I'll add a try-catch block, thanks for spotting. Done http://gerrit.cloudera.org:8080/#/c/16267/3/be/src/exprs/aggregate-functions-ir.cc@1922 PS3, Line 1922: DCHECK(!dst->is_null); > merge can throw an exception, please put it in a try-catch block: Done. I also found one occurrence above, changed that as well. -- To view, visit http://gerrit.cloudera.org:8080/16267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I020aea28d36f9b6ef9fb57c08411f2170f5c24bf Gerrit-Change-Number: 16267 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 06 Aug 2020 12:52:46 +0000 Gerrit-HasComments: Yes
