Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16267 )
Change subject: IMPALA-10017: Implement ds_kll_union() function ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16267/3/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/16267/3/be/src/exprs/aggregate-functions-ir.cc@1851 PS3, Line 1851: etch)) { > The code you linked is urelated here, it is for HLL sketches. However, the Can you also add a similar block for HLL (line 1796)? It is ok to do that in another patch, but I think that it is the simplest to do it here. -- To view, visit http://gerrit.cloudera.org:8080/16267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I020aea28d36f9b6ef9fb57c08411f2170f5c24bf Gerrit-Change-Number: 16267 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 06 Aug 2020 13:12:24 +0000 Gerrit-HasComments: Yes
