Adam Tamas has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16305


Change subject: WIP IMPALA-10012: ds_hll_sketch() results ascii codec decoding 
error fix
......................................................................

WIP IMPALA-10012: ds_hll_sketch() results ascii codec decoding error fix

While the ds_hll_sketch() generates a string value as output the date
is not an ascii encoded text but a bitsketch, because of this, when
the shell get this data it disconnect while it tries to decode it.

This patch contains a solution, where we replace any not UTF-8
decodeable characters if we run into an UnicodeDecodeError.

This solution is working with the Thrift 0.9.3 autogegnerated gen-py
but still fails with Thrift 0.11.0.

Testing:
-manual testing with these protocols: 'hs2-http', 'hs2', 'beeswax'
(-test added to tests/shell/test_shell_interactive.py)

Change-Id: Ic5cfb907871ca83e5f04a39ca9d7a8e138d711a8
---
M shell/impala_client.py
M shell/impala_shell.py
M shell/shell_output.py
M tests/shell/test_shell_interactive.py
4 files changed, 44 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/16305/4
--
To view, visit http://gerrit.cloudera.org:8080/16305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5cfb907871ca83e5f04a39ca9d7a8e138d711a8
Gerrit-Change-Number: 16305
Gerrit-PatchSet: 4
Gerrit-Owner: Adam Tamas <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>

Reply via email to