Adam Tamas has posted comments on this change. ( http://gerrit.cloudera.org:8080/16305 )
Change subject: IMPALA-10012: ds_hll_sketch() results ascii codec decoding error fix ...................................................................... Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/16305/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16305/5//COMMIT_MSG@14 PS5, Line 14: > nit: please wrap at 72 Done http://gerrit.cloudera.org:8080/#/c/16305/5//COMMIT_MSG@14 PS5, Line 14: decodable > typo: I think it is decodable Done http://gerrit.cloudera.org:8080/#/c/16305/5//COMMIT_MSG@17 PS5, Line 17: autogenerated > typo Done http://gerrit.cloudera.org:8080/#/c/16305/5//COMMIT_MSG@18 PS5, Line 18: but still fails with Thrift 0.11.0 > Can you create a ticket for this? As we have discussed, fixing this would n Done (IMPALA-10145) http://gerrit.cloudera.org:8080/#/c/16305/5/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/16305/5/shell/impala_shell.py@1187 PS5, Line 1187: self.output_stream.write(rows) > nit: extra line Done -- To view, visit http://gerrit.cloudera.org:8080/16305 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5cfb907871ca83e5f04a39ca9d7a8e138d711a8 Gerrit-Change-Number: 16305 Gerrit-PatchSet: 9 Gerrit-Owner: Adam Tamas <[email protected]> Gerrit-Reviewer: Adam Tamas <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 04 Sep 2020 10:53:57 +0000 Gerrit-HasComments: Yes
