Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16305 )
Change subject: IMPALA-10012: ds_hll_sketch() results ascii codec decoding error fix ...................................................................... Patch Set 9: (6 comments) only more nits http://gerrit.cloudera.org:8080/#/c/16305/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16305/9//COMMIT_MSG@20 PS9, Line 20: messenge typo http://gerrit.cloudera.org:8080/#/c/16305/9//COMMIT_MSG@21 PS9, Line 21: (not working with beeswax protocol). Can you be more specific about the error thrown? http://gerrit.cloudera.org:8080/#/c/16305/9//COMMIT_MSG@24 PS9, Line 24: -manual testing with these protocols: 'hs2-http', 'hs2', 'beeswax' can you add a bit more info, e.g. the issue can be reproduced with SELECT unhex("aa") http://gerrit.cloudera.org:8080/#/c/16305/9/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/16305/9/shell/impala_shell.py@1232 PS9, Line 1232: 'to find the possible source of the error.' % (e,), file=sys.stderr) nit: +4 indent http://gerrit.cloudera.org:8080/#/c/16305/9/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/16305/9/shell/shell_output.py@40 PS9, Line 40: decodeable nit: decodable http://gerrit.cloudera.org:8080/#/c/16305/9/shell/shell_output.py@41 PS9, Line 41: rowand typo -- To view, visit http://gerrit.cloudera.org:8080/16305 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5cfb907871ca83e5f04a39ca9d7a8e138d711a8 Gerrit-Change-Number: 16305 Gerrit-PatchSet: 9 Gerrit-Owner: Adam Tamas <envokne...@gmail.com> Gerrit-Reviewer: Adam Tamas <envokne...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 04 Sep 2020 11:23:36 +0000 Gerrit-HasComments: Yes
