Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16066 )
Change subject: IMPALA-9482 Support for BINARY columns ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/16066/6/be/src/service/hs2-util.cc File be/src/service/hs2-util.cc: http://gerrit.cloudera.org:8080/#/c/16066/6/be/src/service/hs2-util.cc@273 PS6, Line 273: static void StringExprValuesToHS2TColumnHelper(ScalarExprEvaluator* expr_eval, RowBatch* batch, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/16066/6/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java: http://gerrit.cloudera.org:8080/#/c/16066/6/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@624 PS6, Line 624: HdfsTable binaryTable = (HdfsTable) catalog_.getOrLoadTable("functional", "binary_tbl", line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16066/6/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/16066/6/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@433 PS6, Line 433: "WITH SERDEPROPERTIES ('hbase.columns.mapping'=':key,d:string_col,d:binary_col', " + line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16066/6/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: http://gerrit.cloudera.org:8080/#/c/16066/6/tests/query_test/test_udfs.py@116 PS6, Line 116: y flake8: E501 line too long (92 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/16066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36861a9ca6c2047b0d76862507c86f7f153bc582 Gerrit-Change-Number: 16066 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Aug 2020 18:00:18 +0000 Gerrit-HasComments: Yes
