Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16066 )
Change subject: IMPALA-9482 Support for BINARY columns ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/16066/2/be/src/exec/text-converter.h File be/src/exec/text-converter.h: http://gerrit.cloudera.org:8080/#/c/16066/2/be/src/exec/text-converter.h@63 PS2, Line 63: > Could you mention the new param in the comment above? Done http://gerrit.cloudera.org:8080/#/c/16066/2/be/src/exec/text-converter.h@88 PS2, Line 88: hat cont > Could you mention the new param in the comment above? Done http://gerrit.cloudera.org:8080/#/c/16066/6/be/src/service/hs2-util.cc File be/src/service/hs2-util.cc: http://gerrit.cloudera.org:8080/#/c/16066/6/be/src/service/hs2-util.cc@273 PS6, Line 273: static void StringExprValuesToHS2TColumnHelper(ScalarExprEvaluator* expr_eval, > line too long (95 > 90) Done http://gerrit.cloudera.org:8080/#/c/16066/6/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java: http://gerrit.cloudera.org:8080/#/c/16066/6/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@624 PS6, Line 624: HdfsTable binaryTable = (HdfsTable) catalog_.getOrLoadTable("functional", > line too long (91 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/16066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36861a9ca6c2047b0d76862507c86f7f153bc582 Gerrit-Change-Number: 16066 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 13 Aug 2020 19:05:27 +0000 Gerrit-HasComments: Yes
