Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16066 )
Change subject: IMPALA-9482 Support for BINARY columns ...................................................................... Patch Set 7: (1 comment) I only checked the FE part of the patch. Will continue with the rest tomorrow. http://gerrit.cloudera.org:8080/#/c/16066/7/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: http://gerrit.cloudera.org:8080/#/c/16066/7/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@989 PS7, Line 989: // BINARY is only supported for count + min + max. Lucky that those were the first 3 operators in the for-loop's body. What if later someone adds another function above this line? Let's consider adding these functions for binary after the for loop similarly to ds_hll_union (or avg). -- To view, visit http://gerrit.cloudera.org:8080/16066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36861a9ca6c2047b0d76862507c86f7f153bc582 Gerrit-Change-Number: 16066 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 25 Aug 2020 15:10:02 +0000 Gerrit-HasComments: Yes
