Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 )
Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16419/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16419/2//COMMIT_MSG@12 PS2, Line 12: - TODO: I don't think we have good test coverage on this, I tried to I think what's probably going on is that it's not necessary for correctness - you can write the Kudu row via the Kudu client on any node and it gets sent to the correct tserver internally. It's kinda tricky to test cause it does depend on having a Kudu table around to instantiate the expr. It looks like the original patch just checked the performance. -- To view, visit http://gerrit.cloudera.org:8080/16419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcae34f71b407837e2c5f1b97aa230e490a268df Gerrit-Change-Number: 16419 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 05 Sep 2020 21:02:45 +0000 Gerrit-HasComments: Yes
